Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete vendor folder from source control #38

Open
ZzEeKkAa opened this issue Jan 5, 2023 · 1 comment
Open

Delete vendor folder from source control #38

ZzEeKkAa opened this issue Jan 5, 2023 · 1 comment

Comments

@ZzEeKkAa
Copy link

ZzEeKkAa commented Jan 5, 2023

Vendor folder is not required, since go mods where introduced, so it is just redundant in version control.

@Enrico204
Copy link

It's required, actually, because:

  • with the vendor directory, everyone is able to build this software with no internet connection (after cloning the repo)
  • if some dependency disappear from the original repository, the code is still "buildable"

Note that the "Go module proxy" from Google is not solving the second problem because:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants