Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiples users passwords support #4

Open
shtirlic opened this issue May 8, 2018 · 7 comments · May be fixed by #55
Open

Multiples users passwords support #4

shtirlic opened this issue May 8, 2018 · 7 comments · May be fixed by #55
Labels
no-stale Skip for stales workflow

Comments

@shtirlic
Copy link

shtirlic commented May 8, 2018

I would be a great to provide list of users/password, AFAIK go-socks5 supports this https://github.com/armon/go-socks5/blob/master/credentials_test.go

@serjs
Copy link
Owner

serjs commented Jun 14, 2018

I need some time to look into this feature request. Current server.go based on env variables config, for supporting multi-accounts feature we need to use some custom structure or use file with accounts config maybe

@serjs serjs added the no-stale Skip for stales workflow label Feb 13, 2022
@rezzorix
Copy link

Hey @serjs really like your container.

Did you already have time to look into multiple user authentication?
Would be a great addition.

@Abbode
Copy link

Abbode commented Dec 7, 2023

Or, it'd be better integrating LDAP server authentication and authorization

@alexng353
Copy link

alexng353 commented Jan 12, 2024

Did you already have time to look into multiple user authentication?

Adding multiple-user authentication is not super difficult. I am wondering though, how would you like to see it implemented when the only inputs we can pass to the docker container are strings.

I have written it so that you pass in the environment variable PROXY_CREDENTIALS as a JSON stringified array of username-password pairs:

[
	{ "username": "username1", "password": "password123" },
	{ "username": "username2", "password": "password456" }
]

You can check it out at https://github.com/alexng353/socks5-server/ if you want.
It's just a few lines of code, but I will make a pull request into this repository if this is an acceptable way to do multi-user authentication for this app.

As a side note, the maintainer of the go-socks5 repository seems to have moved on from the project...

@alexng353 alexng353 linked a pull request Jan 13, 2024 that will close this issue
@Abbode
Copy link

Abbode commented Feb 24, 2024

I am wondering though, how would you like to see it implemented

My friend, the best way is with sqlite, if the code is written in python I can help you, as I have experience.
If it's not and you don't want to dive into it, use a JSON file.

@alexng353
Copy link

My friend, the best way is with sqlite,

https://github.com/alexng353/ihostproxy

I eventually ended up doing it with SQLite. I am planning on continuing this project when I have time, but I don't know if I'll ever be able to compete with the de-facto socks5-server haha. If you have any suggestions for my new "fully manageable" proxy project, go ahead and leave an issue. I'll get to it as soon as I have the time.

@Abbode
Copy link

Abbode commented Feb 26, 2024

"Fully manageable" not yet, but I'm working on something now, commercial, I hope to monetize it by giving good service and high speeds multiple configurations proxy.

If you want we can jointly build and scale it.
I also have a brother who makes apps, we can all work together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-stale Skip for stales workflow
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants