Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can not update Angle #51

Closed
kaiwk opened this issue Apr 8, 2021 · 3 comments
Closed

Can not update Angle #51

kaiwk opened this issue Apr 8, 2021 · 3 comments

Comments

@kaiwk
Copy link

kaiwk commented Apr 8, 2021

I can not update gfx/angle as the README said in section Updating Angle. Execute python3 generate_build_data.py gives error following:

Traceback (most recent call last):
File "/Users/kai/projects/mozangle/generate_build_data.py", line 104, in
run()
File "/Users/kai/projects/mozangle/generate_build_data.py", line 20, in run
parse_lib(ANGLE, data[lib], ".common")
File "/Users/kai/projects/mozangle/generate_build_data.py", line 43, in parse_lib
exec(code, env, env)
File "/Users/kai/projects/mozangle/gfx/angle/moz.build.common", line 3, in
if CONFIG['CC_TYPE'] in ('clang', 'clang-cl'):
KeyError: 'CC_TYPE'

@jdm
Copy link
Member

jdm commented Apr 8, 2021

Looks like you need to update

"CONFIG": {
to include CC_TYPE=clang

@kaiwk
Copy link
Author

kaiwk commented Apr 9, 2021

I have tried fix the generate_build_data.py (probably messed up, because i don't know what i am really doing...), finally I found that the newest gfx/angle have a directory called libANGLE, and the build script will include a file from that directory. Just think the README may need a update

@sagudev
Copy link
Member

sagudev commented Dec 23, 2023

#69 landed with new version of angle.

@sagudev sagudev closed this as completed Dec 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants