Enable text-overflow for servo #261
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Any ancestors of this commit are from upstream mozilla-central, with some filtering and renaming. Our patches and sync tooling start here. The sync tooling has all been squashed into this commit, based on: https://github.com/servo/stylo/commits/64731e10dc8ef87ef52aa2fb9f988c3b2530f3a7
This is a rebase of d10ddec Signed-off-by: Oriol Brufau <[email protected]>
Signed-off-by: Oriol Brufau <[email protected]>
Signed-off-by: Oriol Brufau <[email protected]>
Signed-off-by: Oriol Brufau <[email protected]>
Signed-off-by: Oriol Brufau <[email protected]>
Signed-off-by: Oriol Brufau <[email protected]>
Signed-off-by: Oriol Brufau <[email protected]>
Signed-off-by: Oriol Brufau <[email protected]>
Signed-off-by: Nico Burns <[email protected]>
* Define main version number at the workspace level This is the version number that most of the Stylo packages follow * Define in-repo dependencies at the workspace level * Add back newline at end of workspace Cargo.toml Signed-off-by: Nico Burns <[email protected]> --------- Signed-off-by: Nico Burns <[email protected]>
This patch does various things: - Unifies the definitions and implementations of `ImportSheet` among Gecko and Servo. In particular, Servo gains `ImportSheet::Pending`. - Removes unsound `StylesheetContents::from_data()`, which we were keeping as a diff from upstream. - Removes `Stylesheet::update_from_bytes`. It was only used by Servo, which will no longer need it. Signed-off-by: Oriol Brufau <[email protected]>
…ter (servo#251) It was previously taking a `MediaList` parameter, and then wrap it in a locked arc. This was suboptimal for callers that already have an `Arc<Locked<MediaList>>`. Signed-off-by: Oriol Brufau <[email protected]>
It's no longer needed. Signed-off-by: Oriol Brufau <[email protected]>
Signed-off-by: Nico Burns <[email protected]>
* Add all_styles_equal check Signed-off-by: Nico Burns <[email protected]> * Optimise generated damage computations Signed-off-by: Nico Burns <[email protected]> * Use simple ptr::eq instead of styles_may_differ check * Remove optimisation that assumes diff ptr = diff styles Signed-off-by: Nico Burns <[email protected]> --------- Signed-off-by: Nico Burns <[email protected]>
Signed-off-by: Nico Burns <[email protected]>
Signed-off-by: Richard Tjokroutomo <[email protected]>
…ow property" This reverts commit 5fece4c.
Signed-off-by: Richard Tjokroutomo <[email protected]>
* Bug 1995268 - Make StylesheetContents more obviously immutable. r=nicoburns,oriol,#style I want to update the UrlExtraData of the stylesheet contents when cloning for uniqueness. This removes an API that servo uses but that's easily replaceable, see: servo/servo#40024 Differential Revision: https://phabricator.services.mozilla.com/D269200 * Bug 1995304 - Simplify and clean-up stylesheet collection iteration. r=#style,Oriol,nicoburns I want the iter_mut() methods to fix servo/servo#40024. But we can simplify this a little bit nowadays to avoid duplicating a lot of code. Differential Revision: https://phabricator.services.mozilla.com/D269226 * Bug 1995525 - Tweak stylo APIs to make it easier for servo to replace the StylesheetContents without needing a whole new stylesheet. r=oriol,nicoburns,#style Put the Arc<StylesheetContents> under a Locked<T> so that Servo can replace it. Differential Revision: https://phabricator.services.mozilla.com/D269382
Signed-off-by: Richard Tjokroutomo <[email protected]>
Loirooriol
approved these changes
Nov 10, 2025
Collaborator
Loirooriol
left a comment
Loirooriol
left a comment
There was a problem hiding this comment.
Looks good, but let's wait until the Servo PR is ready to land
Author
|
BTW, I re-opened the Servo PR: # 40526 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable
text-overflowfor Servo. Companion PR: #40448