New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent/wrong implementations of Keys property by guarded dictionaries #54

Open

eskesparsoe opened this issue Nov 29, 2016 · 1 comment

Labels

bug

eskesparsoe commented Nov 29, 2016

GuardedDictionary implements the Keys property as 'return dict.Keys;' with a TODO:
//TODO: guard with a read-only wrapper? Probably so!

GuardedSortedDictionary implements the Keys property as 'return null;'

The implementations should be fixed, in particular the one in GuardedSortedDictionary.

The implementations should probably wrap the keys of the wrapped dictionary in a GuardedCollection / GuardedSorted.

JnxF added the bug label

Collaborator

ondfisk commented Dec 15, 2019

Fixed in 3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment