Changes to monit template file are not deployed if an existing config file exists on the server #166
Comments
IanWhitney
pushed a commit
to umn-asr/capistrano-sidekiq
that referenced
this issue
Feb 2, 2018
Fixes seuros#166 Because config was only called within the rescue block, changes to config files would not be uploaded to servers on deployment. Our fix is to always run config before monitoring. This means config files will be uploaded every time that `monit:monitor` is run.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This task uploads the generated monit file to its home on the server.
As far as I can see, that task is only ever called from here, if the attempt to run
monit monitor [service name]fails. Which it would do if the sidekiq/monit config file isn't present.As a result, if there is a sidekiq/monit config file present, that task never fails and changes to the generated monit config file are never uploaded.
We're working around this by adding to our deploys
So we're now always uploading the generated monit config, which is fine.
But is there a better way of handling this? Or a PR I can work on?
The text was updated successfully, but these errors were encountered: