No release tags, broken dependencies

[ypvypv]

Hi,

Just wanted to let you know that you introduced a CMAKE 3.15 hard requirement from external/cpr a week ago. It broke our build that is pulling from this repo.

One way to solve this problem would be to start tagging releases which we can sync to. You have no releases. I am going to git pull to a commit I suppose.

Thanks,
Yuri

[johniez]

Hi,
sorry for that, the dependency on cmake 3.15 is quite strong on older distributions, I understand that.

I tagged the commit before, you can use https://github.com/seznam/httpmockserver/releases/tag/version-0.1 instead of commit hash itself.

[ypvypv]

Hi again,

Actually the problem is worse than I thought. Your tag should still break because you are not pulling tagged versions of cpr and the other library. The external dependencies keep moving even though you tagged your release. Maybe you could pin all your dependencies (and cpr to a version with <= CMAKE 3.10 ). Eventually these dependencies will break your own build.

Cheers,
Yuri

[johniez]

git clone https://github.com/seznam/httpmockserver/
cd httpmockserver
git checkout version-0.1 -b old-cmake
git submodule update --init --recursive
head -1 external/cpr/CMakeLists.txt

Gives me cmake_minimum_required(VERSION 2.8.7) as it should. Tag points to old versions of externals submodules. But maybe you are using it differently?

[johniez]

But anyway, depending on the cpr is really unnecessary here, because it is used in a test case only. It could be made directly by libcurl and this strong dependecy will be gone. I will probably change that.