Spark Hybrid Client - with Just Catalog Client #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-prsingh
commented
Nov 10, 2025
| ) | ||
|
|
||
| // Get Snowflake connection properties from SparkConf only | ||
| val snowflakeProps = spark.conf.getAll.filter { case (key, _) => |
Owner
Author
There was a problem hiding this comment.
TODO: handle feedback from PR#1
src/main/scala/org/apache/spark/sql/snowflake/catalog/SnowflakeFallbackCatalog.scala
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working with this #1 I realized an extension is actually an overkill specially when i came across
V1Tableinterface which keeps an abstraction to work with V2 interface with a source which is mostly V1, which is the same case here i,.e Spark Snowflake connector is a V1 source but iceberg is an V2 sourcewhat this change essentially does is that in loadTable when it sees the table is FGAC protected it creates a V1 Table for snowflake relation which spark later will use to create the Snowflake relation and hence the whole need of having an extension goes aways
a user now just needs this config all in all and not the extension rest all is taken care
I tested with OSS spark it works :)
cc @sfc-gh-hgao