Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Direction of line source as Green's function #122

Open
hagenw opened this issue Dec 7, 2016 · 2 comments
Open

Direction of line source as Green's function #122

hagenw opened this issue Dec 7, 2016 · 2 comments
Assignees
Labels

Comments

@hagenw
Copy link
Member

hagenw commented Dec 7, 2016

In driving_function_imp_wfs_ls() the line source has an orientation in the 3D case, which is provided by the user.
In greens_function_imp() this is not the case for the line source, see line 97. Should we include this there, too?

@trettberg
Copy link
Contributor

Same thing with driving_function_mono_wfs_ls() and greens_function_mono().

It would be nice to do this in a consistent way, but there will be some difficulties:

With the driving functions, xs(3:6) indicates orientation of the virtual line source.
For secondary sources on the other hand, x0(3:6) is needed for direction.

For the moment I think we should leave it as it is.

@hagenw
Copy link
Member Author

hagenw commented Dec 7, 2016

That's true, but at least both driving functions and both Green's functions are consistent at the moment.

It's also ok for me to stay with this for the moment. If someone really needs this functionality she/he could change it then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants