Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use click.UsageError for UI error reporting #139

Closed
jeromekelleher opened this issue Feb 11, 2025 · 2 comments
Closed

Use click.UsageError for UI error reporting #139

jeromekelleher opened this issue Feb 11, 2025 · 2 comments

Comments

@jeromekelleher
Copy link
Contributor

systematically use click.UsageError for UI errors.

xref #138 (comment)
@tomwhite tomwhite mentioned this issue Feb 19, 2025
Merged
@jeromekelleher
Copy link
Contributor Author

Part of my objection to the current code is that it's abusing asserts for UI. If, for example, this code as run with python -O this error would no longer be detected.

@jeromekelleher
Copy link
Contributor Author

Closed in #140

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jeromekelleher