Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more configuration options to Effect system #26

Open
sh0ckR6 opened this issue Oct 8, 2021 · 0 comments
Open

Add more configuration options to Effect system #26

sh0ckR6 opened this issue Oct 8, 2021 · 0 comments
Labels
area: config This issue/pull request is about the configuration system area: effects This issue/pull request is about the effect system type: feature This issue/pull request is about a new feature

Comments

@sh0ckR6
Copy link
Member

sh0ckR6 commented Oct 8, 2021

The effect system as it currently stands feels a little static. There's not really much room for customization, and I think some more configuration options would be beneficial.

New proposed configuration options:

  • Whitelist/Blacklist certain potion effects
    • If a whitelist is defined, all other effects will be implicitly blacklisted.
    • If a blacklist is defined, all other effects will be implicitly whitelisted.
    • There cannot be both a blacklist and whitelist.
  • Individual settings for each potion effect
    • Any setting not explicitly defined will use defaults
  • Option to override the failsafes added for the Wither and Instant Damage effects
    • These were implemented so the player couldn't instantly die to these effects

Example of how this could work:

effects:
  allowed:
    - instant_health:
        amplifier:
          max: 15
          min: 5
        duration:
          max: 60
          min: 1
    - "speed"
  denied:
    - "wither"
    - bad_omen:
        amplifier:
          max: 2
  # Note: "allowed" and "denied" cannot be defined at the same time and are only both here for demonstration
  # Potentially send an error message to the user when loading configuration stating that both "allowed" and "denied" are both defined
@sh0ckR6 sh0ckR6 added area: config This issue/pull request is about the configuration system area: effects This issue/pull request is about the effect system type: feature This issue/pull request is about a new feature labels Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: config This issue/pull request is about the configuration system area: effects This issue/pull request is about the effect system type: feature This issue/pull request is about a new feature
Projects
None yet
Development

No branches or pull requests

1 participant