-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
General discussion #1
Comments
I'd love to start with
I wouldn't bother to write prose that's always out of-sync with what's
see 2. above. What are the requirements? Federation? Standards compliance? (e.g. OAuth, OpenID (Connect?), HTTP Digest?)
KISS, so I'd say no 3rd party code. |
does something like this make sense? http://www.phpspec.net/en/stable/manual/getting-started.html |
Ideally less than 100-200 SLOC. |
If you include services in those, it might be a bit ambitious. |
It looks like unit tests with a bit of additional magic in it. I'd say we stick our good ol' PHPUnit. |
I was thinking about adding Does it make sense to add a |
This could prove handy, yet we need to ensure no sensitive server information or configuration entries can be disclosed this way.
The REST API should by definition return JSON-formatted data, that the client should then parse for further processing (e.g. updating a database, adding custom fields, etc.) Exporting as a Netscape bookmark file to import it somewhere else could turn out to be quite a hazardous operation, depending on the external parser. I'm not sure it's worth (sensible?) making it available through a programmatic-friendly interface. |
About the documentation format, I suggest that we use API Blueprint which is an API documentation specification built on top of markdown. There are a few tools like aglio which renders it in HTML nicely. |
It was a bit chaotic, but I finally got it working automatically: http://shaarli.github.io/api-documentation/ I had to merge everything, but obviously you can still give your feedback on the API doc. |
Thank you! Very good result, and interesting build config. 👍👍👍 |
Timestamps are hidden while logged out whereas the API is authenticated only. It wouldn't cost much to add it to Link IDs are "linkdate" for now (e.g. EDIT: Actually, shaarli/Shaarli#351 is set for v0.8.0. I'll probably work on it after the API, so linkdates ID may not last. |
There are a few things that's need to be defined.
API services
It should describe every services in details. See the first example https://github.com/shaarli/api-documentation/blob/master/api-documentation.md (feel free to propose a better format if you know one).
Different services should be discussed in different issues/PR.
Authentication
Which method are we using? Could be a good idea to provide a few client usage example like done in shaarli/Shaarli#586
Implementation choices
There are a lot of framework and libs to deal with REST API out there. Should we use one of them?
ping @mro @toneiv @pikzen @dimtion
The text was updated successfully, but these errors were encountered: