Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COMPONENTS/Command: Backspace bug #1052

Open
brandonmcconnell opened this issue Jul 27, 2023 · 6 comments · May be fixed by #1286
Open

COMPONENTS/Command: Backspace bug #1052

brandonmcconnell opened this issue Jul 27, 2023 · 6 comments · May be fixed by #1286
Labels
bug Something isn't working component: command

Comments

@brandonmcconnell
Copy link

Once items are filtered from the Command menu, they do not reappear until the Command menu's input field is completely cleared

Screen.Recording.2023-07-26.at.5.37.32.PM.mov
@brandonmcconnell brandonmcconnell changed the title COMPONENTS/Command COMPONENTS/Command: Backspace bug Jul 27, 2023
@ilyichv
Copy link

ilyichv commented Aug 2, 2023

CommandItem is missing value prop. If you want I can fix with a quick PR.

@divyammadhok
Copy link

@brandonmcconnell @ilyichv I also faced the same issue and noticed that an issue has already been created. I went ahead and raised a PR for the same so that the users browsing the docs don't face the same issue

PR: #1286

@miquelvir
Copy link
Contributor

Duplicate of #1450 - already fixed together with others in #1522

Please close as duplicate

@brandonmcconnell
Copy link
Author

@miquelvir @shadcn This is still not fixed. I just checked the latest version of the page I mentioned in the original issue brief, and the same issue persists.

@miquelvir
Copy link
Contributor

@brandonmcconnell yes, the PR is still open (has not been merged). I meant that when the PR is merged then this should be fixed.

@brandonmcconnell
Copy link
Author

@miquelvir Ah got it. Thanks. We should probably call those duplicates out I try e PR in GitHub fashion like…

Fixes #9998
Fixes #9999

I'll check the issue again once that PR gets merged. Thanks for calling that out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working component: command
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants