Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate slow-down in reverse-mode with nested loops in Bezier curves PR #4020

Closed
saipraveenb25 opened this issue Apr 24, 2024 · 1 comment
Closed

Investigate slow-down in reverse-mode with nested loops in Bezier curves PR #4020

saipraveenb25 opened this issue Apr 24, 2024 · 1 comment
Assignees
@saipraveenb25
Labels
goal:quality & productivity Quality issues and issues that impact our productivity coding day to day inside slang
Milestone
Q2 2024 (Spring)

Comments

@saipraveenb25
Copy link
Collaborator

There appears to be some slow-down when using reverse-mode with multiple nested loops. See bezier_curvefit.py in slang-torch PR#1.

Filing this in the main repository because its most likely an issue with recompute/checkpoint policy creating unnecessary intemediates.
@saipraveenb25 saipraveenb25 added the goal:quality & productivity Quality issues and issues that impact our productivity coding day to day inside slang label Apr 24, 2024
@saipraveenb25 saipraveenb25 added this to the Q2 2024 (Spring) milestone Apr 24, 2024
@saipraveenb25 saipraveenb25 self-assigned this Apr 24, 2024
@saipraveenb25
Copy link
Collaborator Author

No compiler changes needed. Fixed by updating user code to take advantage of recomputation.
See for more details: shader-slang/slang-torch#6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@saipraveenb25 saipraveenb25

Labels
goal:quality & productivity Quality issues and issues that impact our productivity coding day to day inside slang
Projects
None yet
Milestone
Q2 2024 (Spring)
Development

No branches or pull requests
1 participant
@saipraveenb25