Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WGSL: Varyings #5067

Open
aleino-nv opened this issue Sep 16, 2024 · 6 comments · May be fixed by #5669
Open

WGSL: Varyings #5067

aleino-nv opened this issue Sep 16, 2024 · 6 comments · May be fixed by #5669
Assignees
@expipiplus1
Labels
goal:client exploration Speculative work for a potential use case. siggraphasia-2024
Milestone
Q4 2024 (Fall)

Comments

@aleino-nv
Copy link
Collaborator

Support varying inputs/outputs
@aleino-nv aleino-nv added kind:enhancement a desirable new feature, option, or behavior goal:forward looking Feature needed at a later date, not connected to a specific use case. labels Sep 16, 2024
@aleino-nv aleino-nv self-assigned this Sep 16, 2024
@jkwak-work jkwak-work added goal:client exploration Speculative work for a potential use case. and removed kind:enhancement a desirable new feature, option, or behavior goal:forward looking Feature needed at a later date, not connected to a specific use case. labels Sep 18, 2024
@bmillsNV bmillsNV added this to the Q4 2024 (Fall) milestone Sep 19, 2024
@aleino-nv aleino-nv removed their assignment Sep 25, 2024
@bmillsNV bmillsNV assigned aleino-nv and unassigned jkwak-work Oct 14, 2024
@aleino-nv
Copy link
Collaborator Author

@csyonghe Do we have plenty of tests that would ensure varyings work well if they pass? If so this task should be covered already.

@bmillsNV bmillsNV added the siggraph2024 Issue targeting SIGGRAPH 2024 label Oct 29, 2024
@csyonghe
Copy link
Collaborator

csyonghe commented Nov 7, 2024

Yes, and I think @jkwak-work is already working on those.

@csyonghe
Copy link
Collaborator

csyonghe commented Nov 7, 2024

@jkwak-work can you comment if varying input/output between vertex/fragment stages is already working and we can close this issue?

@bmillsNV bmillsNV added siggraphasia-2024 and removed siggraph2024 Issue targeting SIGGRAPH 2024 labels Nov 13, 2024
@bmillsNV bmillsNV assigned cheneym2 and expipiplus1 and unassigned aleino-nv and cheneym2 Nov 13, 2024
@jkwak-work
Copy link
Collaborator

Basic support for Varying input/output is implemented with the following PR, but those PRs cover only a few basic semantics.

The remaining task for this issue is to make sure all of semantics for varying inputs and outputs work properly.

@aleino-nv
Copy link
Collaborator Author

aleino-nv commented Nov 25, 2024 •
edited
Loading

Not sure but the PR here #5670 may also be needed in some cases.

@aleino-nv
Copy link
Collaborator Author

...and this PR as well: #5641

@aleino-nv aleino-nv linked a pull request Nov 25, 2024 that will close this issue
Open
expipiplus1 added a commit to expipiplus1/slang that referenced this issue Nov 25, 2024
@expipiplus1
Varying inputs and outputs for wgsl
6a05f1a 
Closes shader-slang#5067

New tests, covering what's declared supported in the WGSL support docs

- tests/wgsl/semantic-coverage.slang
- tests/wgsl/semantic-depth.slang
- tests/wgsl/semantic-dispatch-thread-id.slang
- tests/wgsl/semantic-group-id.slang
- tests/wgsl/semantic-group-index.slang
- tests/wgsl/semantic-group-thread-id.slang
- tests/wgsl/semantic-instance-id.slang
- tests/wgsl/semantic-is-front-face.slang
- tests/wgsl/semantic-position.slang
- tests/wgsl/semantic-sample-index.slang
- tests/wgsl/semantic-vertex-id.slang

WGSL enabled existing tests:
- tests/compute/compile-time-loop.slang
- tests/compute/constexpr.slang
- tests/compute/discard-stmt.slang
- tests/metal/nested-struct-fragment-input.slang
- tests/metal/nested-struct-fragment-output.slang
- tests/metal/nested-struct-multi-entry-point-vertex.slang
- tests/metal/no-struct-vertex-output.slang
- tests/metal/sv_target-complex-1.slang
- tests/metal/sv_target-complex-2.slang
- tests/bugs/texture2d-gather.hlsl
- tests/render/cross-compile-entry-point.slang
- tests/render/nointerpolation.hlsl
- tests/render/render0.hlsl
- tests/render/cross-compile0.hlsl
- tests/render/imported-parameters.hlsl
- tests/render/unused-discard.hlsl

Can't be enabled due to missing wgsl features

- tests/compute/texture-sampling.slang
expipiplus1 added a commit to expipiplus1/slang that referenced this issue Nov 25, 2024
@expipiplus1
Varying inputs and outputs for wgsl
0c1fb21 
Closes shader-slang#5067

New tests, covering what's declared supported in the WGSL support docs

- tests/wgsl/semantic-coverage.slang
- tests/wgsl/semantic-depth.slang
- tests/wgsl/semantic-dispatch-thread-id.slang
- tests/wgsl/semantic-group-id.slang
- tests/wgsl/semantic-group-index.slang
- tests/wgsl/semantic-group-thread-id.slang
- tests/wgsl/semantic-instance-id.slang
- tests/wgsl/semantic-is-front-face.slang
- tests/wgsl/semantic-position.slang
- tests/wgsl/semantic-sample-index.slang
- tests/wgsl/semantic-vertex-id.slang

WGSL enabled existing tests:
- tests/compute/compile-time-loop.slang
- tests/compute/constexpr.slang
- tests/compute/discard-stmt.slang
- tests/metal/nested-struct-fragment-input.slang
- tests/metal/nested-struct-fragment-output.slang
- tests/metal/nested-struct-multi-entry-point-vertex.slang
- tests/metal/no-struct-vertex-output.slang
- tests/metal/sv_target-complex-1.slang
- tests/metal/sv_target-complex-2.slang
- tests/bugs/texture2d-gather.hlsl
- tests/render/cross-compile-entry-point.slang
- tests/render/nointerpolation.hlsl
- tests/render/render0.hlsl
- tests/render/cross-compile0.hlsl
- tests/render/imported-parameters.hlsl
- tests/render/unused-discard.hlsl

Can't be enabled due to missing wgsl features

- tests/compute/texture-sampling.slang
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@expipiplus1 expipiplus1

Labels
goal:client exploration Speculative work for a potential use case. siggraphasia-2024
Projects
None yet
Milestone
Q4 2024 (Fall)
Development

Successfully merging a pull request may close this issue.

Test varying inputs and outputs for wgsl expipiplus1/slang
6 participants
@expipiplus1 @csyonghe @cheneym2 @aleino-nv @jkwak-work @bmillsNV