-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide SlangConfig.cmake in releases #5649
Comments
I can make a pull-request for this since I already have this setup in my local branch. |
Thanks! ov-l. Assigned the issue to you :) |
Side note: you might have to be careful as of what is imported in case of cross-compilation (e.g., to WebAssembly), though I'm not used to configuring CMake installs so it might work out of the box. For my use case I've had to manually deal with it so that slangc executable is setup for the native system while slang library is setup for the target system: |
I added slang as the only target because I just needed that for my use case. If you intend to link with slang, that should work out of the box. slangc on the other hand would be a different target which I have not included in the export target list, and the executable is already installed by default by the existing cmake script (if you build the executable). |
I am having a hard time figuring out what is requested initially. @eliemichel , can you clarify my questions so that we can provide a proper support? |
Sure, I meant "import" as in CMake's vocable of "imported targets" that can be manually created with e.g., In our case, that would mean if download and unzip a binary release to Aside from manual download, this is also very compatible with FetchContent-based approaches to fetch the precompiled binaries and internally (i.e., inside some I believe the approach proposed in #5674 is sound, although I wouldn't consider myself an expert in CMake's import/export mechanism. But let me know if there is actually another recommended way of doing all this! |
This is more of a nice-to-have than a must-have, but it would be really helpful that releases provide such a file (generated by CMake's install process) to ease the import of precompiled binaries in CMake setups!
The text was updated successfully, but these errors were encountered: