Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wgsl: Conditionally enable some tests based on 'half' support #5694

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

aleino-nv
Copy link
Collaborator

Require the 'half' rendering feature for WebGPU, so that we can detect when the f16 feature is not available, for the following tests:

  • tests/language-feature/generics/tuple.slang
  • tests/language-feature/generics/variadic-0.slang

This helps to address issue #5605.

Require the 'half' rendering feature for WebGPU, so that we can detect when
the f16 feature is not available, for the following tests:

- tests/language-feature/generics/tuple.slang
- tests/language-feature/generics/variadic-0.slang

This helps to address issue shader-slang#5605.
@aleino-nv aleino-nv requested a review from a team as a code owner November 27, 2024 13:47
@aleino-nv aleino-nv added the pr: non-breaking PRs without breaking changes label Nov 27, 2024
Copy link
Collaborator

@saipraveenb25 saipraveenb25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@aleino-nv aleino-nv merged commit 0f3ff5f into shader-slang:master Nov 28, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: non-breaking PRs without breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants