From 549a795588863aa4d94cc3aa65a0dc84ed78d996 Mon Sep 17 00:00:00 2001 From: Jess Robinson Date: Tue, 2 Apr 2024 11:35:47 +0000 Subject: [PATCH] refactor(identities): Tidy up code/syntax as requested in review --- src/app/profiles/profile.service.ts | 3 --- src/app/profiles/profiles.editor.modal.ts | 3 +-- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/src/app/profiles/profile.service.ts b/src/app/profiles/profile.service.ts index 60381256f..f07b67e60 100644 --- a/src/app/profiles/profile.service.ts +++ b/src/app/profiles/profile.service.ts @@ -126,9 +126,6 @@ export class ProfileService { this.rmmapi.resendValidationEmail(id).subscribe( reply => { this.refresh(); - if ( !reply ) { - // snackbar error msg? - } }, ); } diff --git a/src/app/profiles/profiles.editor.modal.ts b/src/app/profiles/profiles.editor.modal.ts index 010cdbf2b..68531689d 100644 --- a/src/app/profiles/profiles.editor.modal.ts +++ b/src/app/profiles/profiles.editor.modal.ts @@ -58,9 +58,8 @@ export class ProfilesEditorModalComponent { this.tinymce_plugin = new TinyMCEPlugin(); if (!identity || !Object.keys(identity).length) { identity = new Identity; - const self = this; identity.name = ['first_name', 'last_name'].map((attr) => { - return self.profileService.me[attr]; + return this.profileService.me[attr]; }).join(' '); } if (identity.email) {