Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The report you linked as a reference contradicts your point. Shadowsocks servers **need** protection against replay attacks. The current bloomfilter-based implementation might not be good enough (limited capacity, no persistency, etc). But removing the protection is not the solution. We need protocol changes to achieve full protection. #2956

Closed
0987cronaker opened this issue Nov 20, 2022 · 1 comment

Comments

@0987cronaker
Copy link

    The report you linked as a reference contradicts your point. Shadowsocks servers **need** protection against replay attacks. The current bloomfilter-based implementation might not be good enough (limited capacity, no persistency, etc). But removing the protection is not the solution. We need protocol changes to achieve full protection.

Since you have consistently given downvotes/objections to proposals of any change (shadowsocks/shadowsocks-org#177, shadowsocks/shadowsocks-org#178, shadowsocks/shadowsocks-org#183 (comments)), I'm giving your PR a 👎.

Originally posted by @database64128 in shadowsocks/shadowsocks-rust#556 (comment)

@database64128
Copy link

Why did you take my previous comment out of context and re-post it here? This contains outdated opinions/information and should be deleted.

@Mygod Mygod closed this as completed Nov 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants