Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a new tagged release #1775

Open
link2xt opened this issue Nov 20, 2024 · 7 comments
Open

Make a new tagged release #1775

link2xt opened this issue Nov 20, 2024 · 7 comments

Comments

@link2xt
Copy link
Contributor

link2xt commented Nov 20, 2024

Since all the panics in #1770 are fixed, would be nice to have a new tagged release once there are no blockers. There have been no releases on crates.io for 2 months.

@zonyitoo
Copy link
Collaborator

I am still waiting for hickory-dns's new release.

@link2xt
Copy link
Contributor Author

link2xt commented Nov 23, 2024

@zonyitoo Why is the new release of hickory-dns needed? CI seems to pass and there are no git dependencies in Cargo.toml, so could the release be tagged now and new release with updated hickory-dns tagged later?

@zonyitoo
Copy link
Collaborator

zonyitoo commented Nov 23, 2024

Newer version of hickory-dns upgrades its dependencies like h3, … to the latest. The older one depends on some crates that has been marked deprecated.

Making ServerConfig::new to return a Result is a breaking change. So there must be a new release with a new minor version. So do upgrading hickory-dns to a newer version.

What’s the urgency to make a new release right now with only one change? It would be nice if you could depends on the git repository to test if there are any other bugs haven’t found.

@link2xt
Copy link
Contributor Author

link2xt commented Nov 23, 2024

It's not really urgent, but users keep reporting that attempts to add ss:// proxies crash the whole messenger app. If hickory-dns upgrade comes somewhat soon then it's fine.

@zonyitoo
Copy link
Collaborator

I will wait until December. If hickory-dns didn’t make their stable release, then I would make a new minor release.

@zonyitoo
Copy link
Collaborator

Tracking issue: hickory-dns/hickory-dns#2206

@link2xt
Copy link
Contributor Author

link2xt commented Dec 18, 2024

You can also do this, depending on some exact alpha release: n0-computer/iroh#3021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants