Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task view names Should be checked #453

Closed
FC-FBXL5 opened this issue Jan 26, 2025 · 9 comments
Closed

Task view names Should be checked #453

FC-FBXL5 opened this issue Jan 26, 2025 · 9 comments

Comments

@FC-FBXL5
Copy link

Some naming of the task view panels is incorrect.

AddBase: Generate Sheet Metal base shape
AddWall: Flange parameters
Extrude: Extend parameters
AddFoldWall: Fold on sketch line parameters
Unfold: Unfold sheet metal object
AddCornerRelief: Generate Sheet Metal base shape
AddRelief: Add corner relief on solid
AddJuction: Add Junction Parameters
AddBend: Bend sharp corner Parameters
SketchOnSheet: -
AddCutout: Extruded Cutout Parameters
Forming: Binded faces/edges list
BaseShape: Generate Sheet Metal base shape

  • 2x Copy/paste error: Generate Sheet Metal base shape
  • Inconsistent use of capital letters: S/sheet M/metal, P/parameters
  • Past tense of bind is bound.
@shaise
Copy link
Owner

shaise commented Jan 26, 2025

Thanks, I will take a look.
What do you think is the proper casing of the title? only the first word or all?

@FC-FBXL5
Copy link
Author

I'm not a native English speaker, but as far as I know it should be:
First letter upper case and all following letters lower case, except nouns used as names should start with a capital letter, too.

Sheet Metal: refers to the name of the workbench.
sheet metal: refers to things made of sheet metal.
Unfold: refers to the name of the document object.
unfold: refers to a thing that is unfold or is used as a verb.

BTW - I would prefer SheetMetal for the workbench name like PartDesign, but there seems to be a tendency to split them into separate words, in the GUI and in the wiki.

@shaise
Copy link
Owner

shaise commented Jan 26, 2025

Sounds good to me.
I also like SheetMetal better, I will leave it to the DWG to decide.

shaise added a commit that referenced this issue Jan 26, 2025
@shaise
Copy link
Owner

shaise commented Jan 26, 2025

I have fixed all but SketchOnSheet and AddCutout since I need to revise their task completely

@FC-FBXL5
Copy link
Author

I'm looking forward to the updated task panels. It is a big step forward to be able to (re-) select sketches in the task panel.

@luzpaz
Copy link
Collaborator

luzpaz commented Feb 1, 2025

@shaise close this ticket and open another to track SketchOnSheet and AddCutout ? Or do it from this one ?

@shaise
Copy link
Owner

shaise commented Feb 2, 2025

@luzpaz , this can be closed. The missing task panels are a work in progress, I'll just update my list

@shaise shaise closed this as completed Feb 2, 2025
@luzpaz
Copy link
Collaborator

luzpaz commented Feb 2, 2025

Is the list at issue 412 ?

@shaise
Copy link
Owner

shaise commented Feb 3, 2025

yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants