Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Electron apps outdated #3

Open
Spriithy opened this issue Jun 5, 2015 · 7 comments
Open

Electron apps outdated #3

Spriithy opened this issue Jun 5, 2015 · 7 comments

Comments

@Spriithy
Copy link

Spriithy commented Jun 5, 2015

Hey ! Just to let you know that your way of doing things with electron is already outdated !
There are imperative arguments to : electron-packager such as --platform=, --arch= and --version=.

That means, your source code doesn't compile anymore !

@TheophileDano

@shama
Copy link
Owner

shama commented Jun 5, 2015

Dang! I knew that would happen but didn't think so soon. Thanks for the heads up!

The good news is everything is versioned so the example here should hopefully still work. Please let me know if it doesn't.

@Spriithy
Copy link
Author

Spriithy commented Jun 5, 2015

You should have a look a TideSDK by the way. It is way easier to be honest.
And thanks fort replying

Le ven. 5 juin 2015 18:15, Kyle Robinson Young [email protected] a
écrit :

Dang! I knew that would happen but didn't think so soon. Thanks for the
heads up!

The good news is everything is versioned so the example here
https://github.com/shama/letswritecode/tree/master/packaging-distributing-electron-apps
should hopefully still work. Please let me know if it doesn't.


Reply to this email directly or view it on GitHub
#3 (comment).

@shama
Copy link
Owner

shama commented Jun 6, 2015

Ah interesting, thanks for letting know about TideSDK!

@Spriithy
Copy link
Author

Spriithy commented Jun 6, 2015

Haha if you ever need something about it let me know

Le sam. 6 juin 2015 02:00, Kyle Robinson Young [email protected] a
écrit :

Ah interesting, thanks for letting know about TideSDK!


Reply to this email directly or view it on GitHub
#3 (comment).

@Spriithy
Copy link
Author

Spriithy commented Jun 6, 2015

Well after a quick review of your code in this sample, this shouldn't work.
I've just cloned it, try to run it using the new electron version. Well that's what i used to say, doesn't work ;)

@shama
Copy link
Owner

shama commented Jun 6, 2015

Thanks! I added an annotation to the video indicating that electron-packager >= 4.0.0 now requires the platform, arch, and version options.

@Spriithy
Copy link
Author

Spriithy commented Jun 6, 2015

Sounds great ! But I was wondering, when I type electron-packager ./ app_name --platform=darwin --arch=x86 --version=0.27.2, the app will just launch the Electron default app... I guess I'm doing it wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants