From 1ae100ea1f65773637ff31d0c69a500c234a16b5 Mon Sep 17 00:00:00 2001 From: Shane Dell Date: Fri, 4 Oct 2024 11:30:10 -0400 Subject: [PATCH] Update nightly tests to not run newer versions of VSCode on Windows --- .github/workflows/nightly.yml | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/.github/workflows/nightly.yml b/.github/workflows/nightly.yml index 8d08b7a8b..6af3476e7 100644 --- a/.github/workflows/nightly.yml +++ b/.github/workflows/nightly.yml @@ -28,13 +28,23 @@ jobs: matrix: os: [ macos-12, ubuntu-20.04, windows-2019, macos-latest, ubuntu-latest, windows-latest ] node: [ '16', '18.20.1' ] # version 18.20.2 (current latest of 18) is broken on windows - vscode: [ 'stable', 'insiders' ] + vscode: [ '1.91.1', 'stable', 'insiders' ] java_distribution: [ temurin ] java_version: [ 8, 11, 17 ] exclude: # java 8 not available on latest macos - os: macos-latest java_version: 8 + # Currently newer versions of VSCode don't work the same on Windows, this will need looked into. + # TODO: Remove the below windows excludes once the extension tests are working with newer versions of VSCode + - os: windows-2019 + vscode: 'stable' + - os: windows-2019 + vscode: 'insiders' + - os: windows-latest + vscode: 'stable' + - os: windows-latest + vscode: 'insiders' fail-fast: false # don't immediately fail all other jobs if a single job fails runs-on: ${{ matrix.os }} defaults: