[spike] Multi account for wallet connect

[0xean]

• does wallet connect support multiple accounts
• what is the lift to implement support for this
• do this after all other multi account stuff is wrapped up

[woodenfurniture]

@0xean or @twblack88 do you know of any wallets or dApps that support this? So far it appears to be theoretically possible but without anything to connect to it would be fairly moot.

On the plus side, we do currently support use of multiple accounts when connected as a wallet ✅

When connected as a dApp we only see the first account ❌. This is something we should fix and would actually be useful. The example I see currently is ledger live connected to ShapeShift via WalletConnect, where 2 accounts are connected but we're only displaying the first one.

[0xApotheosis]

It's probably important here to confirm which side of the WalletConnect ecosystem we are talking about.

I believe this would be us, as a wallet, using WalletConnect to connect to other dApps.
It would be theoretically possibly to use our new account management UI to add new chains to the WalletConnect session via the session_update event.

As noted about @woodenfurniture, we are probably not handling the accounts a wallet gives us in the session payload when we are connected as a dApp, as we just use the existing logic to derive accounts, and so I assume if a wallet gives us an account with 0 balance in the session request we don't actually show it in ShapeShift without manually adding it.

[woodenfurniture]

It would be theoretically possibly to use our new account management UI to add new chains to the WalletConnect session via the session_update event.

Agree, we absolutely should be emitting that event when accounts change, even if the dApp on the other end isn't handling this event

[woodenfurniture]

Will turn this into tix

[woodenfurniture]

Ticket for "Make ShapeShift as a WalletConnect dApp connect to all accounts in the request":
#7118

Ticket for "Make ShapeShift as a WalletConnect wallet/dApp emit/respond to session_update event when accounts change":
#7119