Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

THORChain LP - Guard against amount too low for withdraw #7710

Closed
gomesalexandre opened this issue Sep 9, 2024 · 2 comments · Fixed by #7907
Closed

THORChain LP - Guard against amount too low for withdraw #7710

gomesalexandre opened this issue Sep 9, 2024 · 2 comments · Fixed by #7907
Assignees
@kaladinlight
Labels
bug Something isn't working

Comments

@gomesalexandre
Copy link
Contributor

Overview

Precisely what the title says - users withdrawing too small of amounts will end up in Txs not even being observed, only hitting the mempool (which runescan/viewblock is able to leverage and provide useful error messages for e.g https://viewblock.io/thorchain/tx/FE3BE7549136777827D46F46049C7E26FA047128BB4E60D7D5D082EB1617B84B).

References and additional details

N/A

Acceptance Criteria

  • A minimum is introduced for withdraws, that will ensure Txs go through and block users from continuing, with some messaging alongside it

Need By Date

No response

Screenshots/Mockups

No response

Estimated effort

No response
@gomesalexandre gomesalexandre added the bug Something isn't working label Sep 9, 2024
@gomesalexandre gomesalexandre mentioned this issue Sep 9, 2024
Closed
@0xean 0xean moved this from Backlog to Up next / groomed in ShapeShift Dashboard Sep 9, 2024
@kaladinlight kaladinlight self-assigned this Sep 19, 2024
@kaladinlight kaladinlight moved this from Up next / groomed to In progress in ShapeShift Dashboard Sep 19, 2024
@0xean
Copy link
Contributor

0xean commented Sep 30, 2024

disable when failure is for sure, otherwise leave as is

@0xean
Copy link
Contributor

0xean commented Oct 7, 2024

use 4x buffer to avoid failed transactions and potential for failed tx's

@kaladinlight kaladinlight mentioned this issue Oct 8, 2024
Merged
1 task
@kaladinlight kaladinlight moved this from In progress to In review in ShapeShift Dashboard Oct 8, 2024
@github-project-automation github-project-automation bot moved this from In review to Done in ShapeShift Dashboard Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kaladinlight kaladinlight

Labels
bug Something isn't working
Projects
ShapeShift Dashboard
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: thorchain remove liquidity bug fixes shapeshift/web
3 participants
@0xean @gomesalexandre @kaladinlight