Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send of Atom modal doesnt update once the transaction has completed #7777

Closed
2 tasks done
MBMaria opened this issue Sep 20, 2024 · 6 comments · Fixed by shapeshift/unchained#1061
Closed
2 tasks done
Assignees
Labels
bug Something isn't working needs engineering Requires engineering input before bounty

Comments

@MBMaria
Copy link

MBMaria commented Sep 20, 2024

Overview

When doing a send of Atom the send modal stays on waiting for confirmation and doesn't change to Success once the transaction has completed

References and additional details

image

https://jam.dev/c/f8ffb575-0bc0-4895-af4b-10a923ac6bd3

Acceptance Criteria

Modal should update once send has completed

Need By Date

No response

Screenshots/Mockups

No response

Ownership

  • If my bounty needs engineering or needs product I have added the respective labels on the right
  • As the sponsor of this bounty I will review the changes in a preview environment (ops/product) or review the PR (engineering)

Estimated effort

No response

Sponsor / Stakeholder

No response

Bounty Hunters

  • Join our discord
  • Include an expected timeline for you to complete work in the work plan when you apply for this bounty!
  • Please refer to this link for some basic info
  • Please do not start work on this issue until you are approved in Gitcoin.
@MBMaria MBMaria added bug Something isn't working needs engineering Requires engineering input before bounty labels Sep 20, 2024
@0xean 0xean moved this from Backlog to Up next / groomed in ShapeShift Dashboard Sep 20, 2024
@kaladinlight kaladinlight self-assigned this Sep 27, 2024
@kaladinlight
Copy link
Contributor

@MBMaria can you try and confirm this again on your end? Cosmos tx handing in unchained was completely broken at one point and thinking this was the cause, but not sure if this was seen after that fix.

I just tested on my end and saw the confirmation right away:
image

@kaladinlight kaladinlight moved this from Up next / groomed to In progress in ShapeShift Dashboard Oct 1, 2024
@MBMaria
Copy link
Author

MBMaria commented Oct 1, 2024

hi @kaladinlight I'm still experiencing this. using a chrome incognito tab just now.
image

@kaladinlight
Copy link
Contributor

I have seen it as well, seems like the websockets degrade the longer they are up. Tried to push a small change and some additional debug logs to try and track things down more.

@kaladinlight
Copy link
Contributor

Changes look to have made a difference. Seeing detected transaction all through yesterday afternoon and again this morning. Can you give another spot check on your end @MBMaria please 🙏

@kaladinlight
Copy link
Contributor

Damnit, just checked again and no update. So that means the websockets are just stopping sending data on the node side of things while technically staying alive so we don't trigger a reconnect. I have a couple more thoughts and will hopefully get to the the bottom of this soon.

@kaladinlight
Copy link
Contributor

Ok, most recent ws durability improvements look to be working. Going to close this at this time. If there are more issues or instances, would like to open up a fresh ticket to start looking into again.

@github-project-automation github-project-automation bot moved this from In progress to Done in ShapeShift Dashboard Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs engineering Requires engineering input before bounty
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants