Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade shapeshift 0x API proxy to support permit2 endpoints #7784

Closed
woodenfurniture opened this issue Sep 22, 2024 · 0 comments · Fixed by shapeshift/unchained#1047
Closed

Upgrade shapeshift 0x API proxy to support permit2 endpoints #7784

woodenfurniture opened this issue Sep 22, 2024 · 0 comments · Fixed by shapeshift/unchained#1047
Assignees
@kaladinlight

Comments

@woodenfurniture
Copy link
Member

woodenfurniture commented Sep 22, 2024 •
edited
Loading

Overview

Our 0x API proxy needs to include the new permit2 api endpoints with specific header 0x-version: v2.

References and additional details

See required header Parameters in https://0x.org/docs/api#tag/Swap/operation/swap::permit2::getQuote

image

Acceptance Criteria

2 additional endpoints added to 0x proxy with correct version and api key headers set:

  • /swap/permit2/price
  • /swap/permit2/quote

Need By Date

No response

Screenshots/Mockups

No response

Estimated effort

No response
@woodenfurniture woodenfurniture changed the title Upgrade shapeshift 0x swapper proxy to support permit2 endpoints Upgrade shapeshift 0x API proxy to support permit2 endpoints Sep 23, 2024
@0xean 0xean moved this from Backlog to Up next / groomed in ShapeShift Dashboard Sep 23, 2024
@kaladinlight kaladinlight self-assigned this Sep 24, 2024
@kaladinlight kaladinlight moved this from Up next / groomed to In progress in ShapeShift Dashboard Sep 24, 2024
@kaladinlight kaladinlight mentioned this issue Sep 24, 2024
Merged
@kaladinlight kaladinlight linked a pull request Sep 24, 2024 that will close this issue
feat: add zrx proxy shapeshift/unchained#1047
Merged
@kaladinlight kaladinlight moved this from In progress to In review in ShapeShift Dashboard Sep 24, 2024
@github-project-automation github-project-automation bot moved this from In review to Done in ShapeShift Dashboard Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kaladinlight kaladinlight

Labels
None yet
Projects
ShapeShift Dashboard
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add zrx proxy shapeshift/unchained
3 participants
@0xean @kaladinlight @woodenfurniture