Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swapper infinite load state #7789

Closed
kaladinlight opened this issue Sep 23, 2024 · 1 comment · Fixed by #7818
Closed

Swapper infinite load state #7789

kaladinlight opened this issue Sep 23, 2024 · 1 comment · Fixed by #7818
Assignees
@woodenfurniture
Labels
bug Something isn't working

Comments

@kaladinlight
Copy link
Contributor

Overview

The swapper UI stays in an infinite load state if a thorchain (maybe others?) quote fails.

References and additional details

image

Acceptance Criteria

  • Swapper should load and show available quotes even if some quotes failed under the hood

Need By Date

No response

Screenshots/Mockups

No response

Estimated effort

No response
@kaladinlight kaladinlight added the bug Something isn't working label Sep 23, 2024
@0xean
Copy link
Contributor

0xean commented Sep 23, 2024

Need state to show no quotes available

@0xean 0xean moved this from Backlog to Up next / groomed in ShapeShift Dashboard Sep 23, 2024
@woodenfurniture woodenfurniture self-assigned this Sep 25, 2024
@woodenfurniture woodenfurniture moved this from Up next / groomed to In progress in ShapeShift Dashboard Sep 25, 2024
@woodenfurniture woodenfurniture mentioned this issue Sep 26, 2024
Merged
1 task
@woodenfurniture woodenfurniture moved this from In progress to In review in ShapeShift Dashboard Sep 26, 2024
@github-project-automation github-project-automation bot moved this from In review to Done in ShapeShift Dashboard Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@woodenfurniture woodenfurniture

Labels
bug Something isn't working
Projects
ShapeShift Dashboard
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: dont display loading state when completed quote request has no results shapeshift/web
3 participants
@0xean @kaladinlight @woodenfurniture