-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: dont display loading state when completed quote request has no results #7818
Conversation
88f9687
to
3c3ce82
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some Qs to remove confusion re: discrepencies between intent/implementation, but functionally LGTM!
3c3ce82
to
c1fa8be
Compare
Description
Resolves state issue in trade UI where lack of non-errored quoted is treated as loading state, resulting in infinite spinner when all swappers failed to return a quote.
Issue (if applicable)
closes #7789
Risk
Low risk, though considering the massive usage of the swapper feature we should review it with added caution.
Affects quotes and loading state.
Testing
The easiest way to test this is by trying to get a quote with assets which are THOR only (e.g UTXOs, or UTXO<->ATOM would work too), and then blocking the
swap*
domain.To do so, proceed as follow:
thor swap
. You'll notice request/s matching theswap?amount=
pattern, click on anyEngineering
Operations
Screenshots (if applicable)
Demo using monkey patch to force simulated thorchain swapper error:
https://jam.dev/c/39fb191a-25b1-4f15-8505-c02454b8a60a