Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lifi bridge timer starts counting down before executing the trade #7806

Closed
2 tasks done
MBMaria opened this issue Sep 25, 2024 · 1 comment · Fixed by #7809
Closed
2 tasks done

Lifi bridge timer starts counting down before executing the trade #7806

MBMaria opened this issue Sep 25, 2024 · 1 comment · Fixed by #7809
Assignees
Labels
bug Something isn't working needs engineering Requires engineering input before bounty

Comments

@MBMaria
Copy link

MBMaria commented Sep 25, 2024

Overview

When doing a lifi trade with a timer, it starts counting down as soon as its on the trade page rather than when the trade is broadcasted.

References and additional details

image
https://jam.dev/c/a0699433-f230-4b1a-aa89-e80ddc659ea6

Acceptance Criteria

Timer should start when tx is signed

Need By Date

No response

Screenshots/Mockups

No response

Ownership

  • If my bounty needs engineering or needs product I have added the respective labels on the right
  • As the sponsor of this bounty I will review the changes in a preview environment (ops/product) or review the PR (engineering)

Estimated effort

No response

Sponsor / Stakeholder

No response

Bounty Hunters

  • Join our discord
  • Include an expected timeline for you to complete work in the work plan when you apply for this bounty!
  • Please refer to this link for some basic info
  • Please do not start work on this issue until you are approved in Gitcoin.
@MBMaria MBMaria added bug Something isn't working needs engineering Requires engineering input before bounty labels Sep 25, 2024
@MBMaria
Copy link
Author

MBMaria commented Sep 25, 2024

Realising this is on MM - and it starts once you sign the tx in shapeshift - however will be counting down even before you sign in the mm pop up ... nit sure if his can be fixed or not .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs engineering Requires engineering input before bounty
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants