Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New splash for connect wallet does not translate all text to new language selection #7816

Closed
2 tasks done
MBMaria opened this issue Sep 26, 2024 · 3 comments · Fixed by #7880
Closed
2 tasks done

New splash for connect wallet does not translate all text to new language selection #7816

MBMaria opened this issue Sep 26, 2024 · 3 comments · Fixed by #7880
Labels
bug Something isn't working needs engineering Requires engineering input before bounty needs product Requires product input before bounty

Comments

@MBMaria
Copy link

MBMaria commented Sep 26, 2024

Overview

When selecting a language different from English on the new connect wallet splash, not all the text is translated

References and additional details

image

https://jam.dev/c/91cb88fa-2841-4839-8a89-3086c0c4e922

Acceptance Criteria

Changing language should translate all text

Need By Date

No response

Screenshots/Mockups

No response

Ownership

  • If my bounty needs engineering or needs product I have added the respective labels on the right
  • As the sponsor of this bounty I will review the changes in a preview environment (ops/product) or review the PR (engineering)

Estimated effort

No response

Sponsor / Stakeholder

No response

Bounty Hunters

  • Join our discord
  • Include an expected timeline for you to complete work in the work plan when you apply for this bounty!
  • Please refer to this link for some basic info
  • Please do not start work on this issue until you are approved in Gitcoin.
@MBMaria MBMaria added bug Something isn't working needs engineering Requires engineering input before bounty needs product Requires product input before bounty labels Sep 26, 2024
@firebomb1
Copy link
Contributor

firebomb1 commented Sep 26, 2024

Thanks for the ticket @MBMaria, these all seem to be translatable and will be translated during the next MKBD Translation sync which occur biweekly. The next one starts next Monday, September 30th, once translators will have translated the strings in the 9 languages supported by the app the changes will be merged and released in the app eventually.

@0xean
Copy link
Contributor

0xean commented Sep 30, 2024

closing as temporary

@0xean 0xean closed this as completed Sep 30, 2024
@github-project-automation github-project-automation bot moved this from Backlog to Done in ShapeShift Dashboard Sep 30, 2024
@firebomb1
Copy link
Contributor

I would have tagged the issue in the upcoming merge later this week, but thx for preemptively closing it, it's currently in the works 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs engineering Requires engineering input before bounty needs product Requires product input before bounty
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants