Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to trade LINK to M87 on Eth #7827

Closed
2 tasks done
MBMaria opened this issue Sep 26, 2024 · 4 comments
Closed
2 tasks done

Unable to trade LINK to M87 on Eth #7827

MBMaria opened this issue Sep 26, 2024 · 4 comments
Labels
bug Something isn't working needs engineering Requires engineering input before bounty

Comments

@MBMaria
Copy link

MBMaria commented Sep 26, 2024

Overview

When trying to trade LINK on eth to M87 on Eth getting an error of Something went wrong. Happens both Portals and 0x swapper

References and additional details

image

https://jam.dev/c/4314206f-2168-494f-8fc1-2808feb23327

Acceptance Criteria

Should be able to swap to M87?

Need By Date

No response

Screenshots/Mockups

No response

Ownership

  • If my bounty needs engineering or needs product I have added the respective labels on the right
  • As the sponsor of this bounty I will review the changes in a preview environment (ops/product) or review the PR (engineering)

Estimated effort

No response

Sponsor / Stakeholder

No response

Bounty Hunters

  • Join our discord
  • Include an expected timeline for you to complete work in the work plan when you apply for this bounty!
  • Please refer to this link for some basic info
  • Please do not start work on this issue until you are approved in Gitcoin.
@MBMaria MBMaria added bug Something isn't working needs engineering Requires engineering input before bounty labels Sep 26, 2024
@gomesalexandre
Copy link
Contributor

@MBMaria this is one of those unfortunate upstream issues: the error is coming from 0x with code IncompleteTransformERC20Error.
Researching that, I can see that:

At this time 0xAPI only works with standard ERC20/BEP20 tokens which does not include tokens (like SHIBIC) that take a fee on transfer.

Can close at wontfix, though since this is not the first time this happens, could be worth it curating a list of untradeable assets and disabling them in swapper. If you believe there is value in that, happy to create an issue for that and raise it next sync!

@MBMaria
Copy link
Author

MBMaria commented Sep 29, 2024

hi @gomesalexandre thanks for looking into this. Yes I'd say go ahead and close then. If we could disable the pair in the swappers that would be great. I think there has been 2 or 3 assets we have come across like this? (cant remember what they are lol) Is there a way to find all the assets that are blocked upstream?

@gomesalexandre
Copy link
Contributor

hi @gomesalexandre thanks for looking into this. Yes I'd say go ahead and close then. If we could disable the pair in the swappers that would be great. I think there has been 2 or 3 assets we have come across like this? (cant remember what they are lol) Is there a way to find all the assets that are blocked upstream?

Unfortunately this is more of a "try it out and find out" kind of issue, AFAIK there really isn't a definite list anywhere.

Let's keeep those PRs handy somewhere, and if this happens again and for enough assets to become a problem, happy for ops to curate a list which we could use as a blocklist!

@MBMaria
Copy link
Author

MBMaria commented Oct 13, 2024

@gomesalexandre - is this the same error with KNDX?
https://jam.dev/c/cfbe6dee-b5ec-43a1-ba93-28024cdebd0b
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs engineering Requires engineering input before bounty
Projects
Status: Done
Development

No branches or pull requests

2 participants