Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attention Warning in trade modal spans across whole page instead of just the modal #7946

Closed
2 tasks done
MBMaria opened this issue Oct 16, 2024 · 2 comments
Closed
2 tasks done

Attention Warning in trade modal spans across whole page instead of just the modal #7946

MBMaria opened this issue Oct 16, 2024 · 2 comments
Assignees
@woodenfurniture
Labels
bug Something isn't working needs engineering Requires engineering input before bounty

Comments

@MBMaria
Copy link

MBMaria commented Oct 16, 2024

Overview

When there is a warning on trades, the attention banner spans across the whole page instead of just the modal like it used to

References and additional details

image

https://jam.dev/c/ff267f2d-3ce6-40ee-ab0e-fe1a5f670a0f

Acceptance Criteria

Warning should be width of modal

Need By Date

No response

Screenshots/Mockups

No response

Ownership

  • If my bounty needs engineering or needs product I have added the respective labels on the right
  • As the sponsor of this bounty I will review the changes in a preview environment (ops/product) or review the PR (engineering)

Estimated effort

No response

Sponsor / Stakeholder

No response

Bounty Hunters

  • Join our discord
  • Include an expected timeline for you to complete work in the work plan when you apply for this bounty!
  • Please refer to this link for some basic info
  • Please do not start work on this issue until you are approved in Gitcoin.
@MBMaria MBMaria added bug Something isn't working needs engineering Requires engineering input before bounty labels Oct 16, 2024
@0xApotheosis
Copy link
Contributor

Expected UI:

Screenshot 2024-10-16 at 14 28 36

This was referenced Oct 16, 2024
Closed
Closed
@woodenfurniture woodenfurniture self-assigned this Oct 16, 2024
@woodenfurniture woodenfurniture moved this from Backlog to In progress in ShapeShift Dashboard Oct 16, 2024
@woodenfurniture woodenfurniture mentioned this issue Oct 16, 2024
Merged
1 task
@0xApotheosis
Copy link
Contributor

Closed by #7953

@github-project-automation github-project-automation bot moved this from In progress to Done in ShapeShift Dashboard Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@woodenfurniture woodenfurniture

Labels
bug Something isn't working needs engineering Requires engineering input before bounty
Projects
ShapeShift Dashboard
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: swapper warning acks shapeshift/web
fix: swapper warning acks, attempt 2 shapeshift/web
3 participants
@0xApotheosis @MBMaria @woodenfurniture