Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rates persisted across a wallet connect and other user actions #7979

Open
0xean opened this issue Oct 21, 2024 · 1 comment
Open

Rates persisted across a wallet connect and other user actions #7979

0xean opened this issue Oct 21, 2024 · 1 comment
Assignees

Comments

@0xean
Copy link
Contributor

0xean commented Oct 21, 2024

When the swapper is exposed externally without a wallet connected and a user receives rates and then decides to connect a wallet, we want to ensure there isn't a full refresh required and they dont get kicked back into the flow.

Uniswap does a nice job of this ( https://app.uniswap.org/swap ) as an example.

AC

  • swapper state persists upon wallet connection
  • clicking back button from confirm screen returns to previous state vs full refresh
  • moving from "mini swapper" on the markets page to the "full swapper" persists state
@0xean 0xean moved this from Backlog to Up next / groomed in ShapeShift Dashboard Oct 21, 2024
@0xean 0xean changed the title Rates persisted across a wallet connect Rates persisted across a wallet connect and other user actions Oct 21, 2024
@0xApotheosis 0xApotheosis self-assigned this Nov 18, 2024
@0xApotheosis 0xApotheosis moved this from Up next / groomed to In progress in ShapeShift Dashboard Nov 18, 2024
@0xApotheosis
Copy link
Contributor

Spoke with @gomesalexandre and I'll focus on reviewing #8079 and wait until that goes in before starting this guy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In progress
Development

No branches or pull requests

3 participants
@0xean @0xApotheosis and others