Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lifi stargate v2 swapper gives an error while the trade is completing to contact lifi discord due to an unexpected error #7988

Closed
2 tasks done
MBMaria opened this issue Oct 22, 2024 · 1 comment · Fixed by #8003
Assignees
Labels
bug Something isn't working needs engineering Requires engineering input before bounty

Comments

@MBMaria
Copy link

MBMaria commented Oct 22, 2024

Overview

Using stargate v2 swapper for lifi trade gives an error after broadcasting the transaction to contact the lifi discord . Trade still completes as expected but could be disconcerting for users to receive what seems like an unnecessary error.

References and additional details

Uploading image.png…
https://jam.dev/c/ed275e47-2200-48d5-8166-0e3704594bb1

Acceptance Criteria

Should not show error message if there is no error

Need By Date

No response

Screenshots/Mockups

No response

Ownership

  • If my bounty needs engineering or needs product I have added the respective labels on the right
  • As the sponsor of this bounty I will review the changes in a preview environment (ops/product) or review the PR (engineering)

Estimated effort

No response

Sponsor / Stakeholder

No response

Bounty Hunters

  • Join our discord
  • Include an expected timeline for you to complete work in the work plan when you apply for this bounty!
  • Please refer to this link for some basic info
  • Please do not start work on this issue until you are approved in Gitcoin.
@MBMaria MBMaria added bug Something isn't working needs engineering Requires engineering input before bounty labels Oct 22, 2024
@woodenfurniture
Copy link
Member

woodenfurniture commented Oct 24, 2024

Stargate is meant to be blacklisted from the swapper, so this looks to be more of an issue with not blocking Stargate V2 (Economy Mode).

image

image

@woodenfurniture woodenfurniture self-assigned this Oct 24, 2024
@woodenfurniture woodenfurniture moved this from Backlog to In progress in ShapeShift Dashboard Oct 24, 2024
@woodenfurniture woodenfurniture moved this from In progress to In review in ShapeShift Dashboard Oct 24, 2024
@github-project-automation github-project-automation bot moved this from In review to Done in ShapeShift Dashboard Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs engineering Requires engineering input before bounty
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants