Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOL asset available as an option in Swapper with no path #8016

Closed
purelycrickets opened this issue Oct 28, 2024 · 2 comments · Fixed by #8039 or #8063
Closed

SOL asset available as an option in Swapper with no path #8016

purelycrickets opened this issue Oct 28, 2024 · 2 comments · Fixed by #8039 or #8063
Assignees
Labels
enhancement New feature or request needs engineering Requires engineering input before bounty

Comments

@purelycrickets
Copy link

Overview

Currently in release, SOL is available as an asset to be traded into even though there are no paths available to users.

References and additional details

SOL as an asset to be traded via swapper: image-2

Acceptance Criteria

Is it possible to have SOL omitted from swapper as an asset that can be traded until a route is available for it to be traded?

Need By Date

No response

Screenshots/Mockups

No response

Estimated effort

No response

@purelycrickets purelycrickets added enhancement New feature or request needs engineering Requires engineering input before bounty labels Oct 28, 2024
@0xean 0xean moved this from Backlog to Up next / groomed in ShapeShift Dashboard Oct 28, 2024
@kaladinlight kaladinlight moved this from Up next / groomed to In review in ShapeShift Dashboard Oct 30, 2024
@github-project-automation github-project-automation bot moved this from In review to Done in ShapeShift Dashboard Oct 30, 2024
@MBMaria
Copy link

MBMaria commented Oct 31, 2024

@kaladinlight - not sure if the asset page of sol can have the trade widget greyed out? Even if you enter a custom address it just looks like its fetching a rate the whole time
https://jam.dev/c/458838db-bd6f-480a-958b-cfeb85b9da5d

@kaladinlight
Copy link
Contributor

@kaladinlight - not sure if the asset page of sol can have the trade widget greyed out? Even if you enter a custom address it just looks like its fetching a rate the whole time https://jam.dev/c/458838db-bd6f-480a-958b-cfeb85b9da5d

Good catch. I updated to use FOX as the default buy asset on solana asset pages

@github-project-automation github-project-automation bot moved this from Up next / groomed to Done in ShapeShift Dashboard Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs engineering Requires engineering input before bounty
Projects
Status: Done
3 participants