Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executable file #217

Open
daiyam opened this issue Aug 10, 2021 · 7 comments
Open

executable file #217

daiyam opened this issue Aug 10, 2021 · 7 comments

Comments

@daiyam
Copy link
Contributor

daiyam commented Aug 10, 2021

When a file is an executable in the config repository, the file isn't executable in the target project.

@epszaw
Copy link
Member

epszaw commented Aug 10, 2021

Can you give an example?

@daiyam
Copy link
Contributor Author

daiyam commented Aug 10, 2021

https://github.com/daiyam/sharec-config/blob/master/packages/sharec-base/configs/.husky/commit-msg is one of the files.

@epszaw
Copy link
Member

epszaw commented Aug 10, 2021

I'm not sure, that it's a good idea to count executable file as config and I think, sharec shouldn't handle this kind of files.

@epszaw epszaw closed this as completed Aug 10, 2021
@daiyam
Copy link
Contributor Author

daiyam commented Aug 10, 2021

Why not, it's part of a default config.

@daiyam
Copy link
Contributor Author

daiyam commented Aug 10, 2021

Do you want to limit sharec to only configuration files?
I've look at the code and it doesn't support binary files (like an icon, a font or an image) due to read/write in 'utf-8'.

@epszaw
Copy link
Member

epszaw commented Aug 10, 2021

Let's try to imagine how to satisfy your requirements in future :)

@epszaw epszaw reopened this Aug 10, 2021
@daiyam
Copy link
Contributor Author

daiyam commented Aug 10, 2021

Thx

I was thinking maybe the files commencing with a shebang (#!) can become executable.
For binary files like .jpg, we could skip the merge and directly do a binary copy.

I will try to make a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants