-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unable to locate OSRM module. #52
Comments
@josiekre I just pushed a fix for this, adding additional search steps to find the location of OSRM in node user directories. I tested this on docker and was able to get it to work: Dockerfile:
Docker image build: Run match on test data: Thanks for investigating the docker steps -- I think that this will be useful of other users, especially those on Windows. The tricky part is making it easy to access data stored on the host computer from inside the docker container. I'm going to investigate if there are standardized approaches for dockerized CLI workflows and will push up this image once we can document the steps. |
feature: #53 adding manual override for OSRM path |
Worked! Thanks for the quick fix. |
Using the following Dockerfile with the fix from #50, points are matching from the tests but lines are not. There's a problem finding the OSRM module.
I looked into
src/graph.ts
.getOSRMDirectory()
should be finding the path correctly given where I can find it inside the Docker.sharedstreets-js/src/graph.ts
Lines 43 to 46 in 9b08e31
Inside the Docker, OSRM gets installed at
/home/node/.npm-global/lib/node_modules/sharedstreets/node_modules/osrm/
.The text was updated successfully, but these errors were encountered: