-
-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Looks like a conversion error between rpm and rad/s. #187
Comments
Thank you for your feedback. Looks like this is a duplicate of #50. Please see my answer there (#50 (comment)) and let me know if that makes sense. |
Thank you for the answer and sorry for the duplication. Perhaps it may be useful to have some kind of disclaimer when dealing with dimensionless units since mistakes may be silently returned. Anyway, congratulations on this very useful project. |
👍
That's kind of the reason why I wrote insect 😄 Calculating without units can be dangerous. Insect even provides a few "dummy" units like
In your example, you could use one of these dummy units (say
Anyway, I think the really confusing part here is probably the unit "rpm" which a lot of people think is somehow connected with "rotation" but is really just defined as "1 / min". I guess we could add a section to the FAQs about calculations with RPM. What do you think? |
@sharkdp I'd like to reopen this issue, as I believe RPM is in fact defined incorrectly. I understand the logic behind a radian being a m/m, hence a scalar. Also I agree RPM is the same base unit as Hz: 1/s, but it should be scaled so that 1 RPM is 2π / min. That's the way it is done in GNU units:
Compared to the behaviour of insect:
Also it makes sense to introduce the unit 'revolution(s)' or short 'rev', equal to 2π radians, so that you can define RPM as rev/min. That's the way it's done in GNU units also:
Actually in GNU units a revolution is defined as turn which is defined as circle which is defined as 2 pi radian. It might be useful to include those units too.
Thanks for the great tool! |
Wikipedia actually talks about those two conflicting definitions:
In I have added a FAQ entry (https://github.com/sharkdp/insect#faq) regarding RPM some time ago, but this keeps on popping up. So I guess it's time for me to reconsider my initial choice. The fact that we are not compatible with If someone wants to make this change (and update the FAQ/documentation), I'd be okay with that.
Sounds like a great idea 👍
Thank you very much for the feedback! |
How I understand that is that the Hz is the one that can be interpreted differently, not rpm. So when 1 rpm = 1/60 Hz, then 1 Hz means one revolution per second (= 2π radians per second). On the Hertz Wikipedia page that is explained more clearly:
Confusing stuff :) It does make sense to have angles be a dimension, but I guess the SI people have thought long about what would be the best choice. From the radian Wikipedia page:
But yeah, some things are the way they are, even though things could have been so much easier with decimal time, or even using base 12 as default instead of 10.
Good, as it feels like a good habit to try a new language every once in a while and I didn't try PureScript yet I might give it a try. |
In the follow-up project, Numbat, we can now easily play with this. If you are interested in more details, please see sharkdp/numbat#91 and sharkdp/numbat#167. You can try the normal version of Numbat here (same behavior as Insect): https://numbat.dev/ The latter version allows you to do:
I'd be glad to get some feedback on this. |
Tried to convert 10rpm to rad/s but it seems to give a bad result.
But 10rpm * 2pi / 60 = 1.047... rad/s
Is this a bug or am I using the tool the wrong way?
The text was updated successfully, but these errors were encountered: