Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RadarAxis calls onAxisLabelClick on mouseover #13

Open
matthewcocco opened this issue Feb 23, 2019 · 0 comments
Open

RadarAxis calls onAxisLabelClick on mouseover #13

matthewcocco opened this issue Feb 23, 2019 · 0 comments

Comments

@matthewcocco
Copy link

matthewcocco commented Feb 23, 2019

In the v-next branch, the RadarAxis component calls the onClick method on mouseover.

I believe the cause is here: https://github.com/shauns/react-d3-radar/blob/v-next/src/RadarAxis.js#L71-L72

This causes (what I think is) unexpected behavior for an onAxisLabelClick prop passed from the top level Radar is triggered every time an axis label is moused over, in addition to when it is clicked.

The relevant changes to add an onAxisLabelMouseover prop and pass that value instead to the onMouseover of the RadarAxis component are in:

  • RadarAxis.js
  • Radar.js
  • RadarWrapper.js

I have some changes at matthewcocco@8431850 that pass the test:all suite, and can open a PR if you'd like, @shauns -- would you be open to accepting it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant