You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This causes (what I think is) unexpected behavior for an onAxisLabelClick prop passed from the top level Radar is triggered every time an axis label is moused over, in addition to when it is clicked.
The relevant changes to add an onAxisLabelMouseover prop and pass that value instead to the onMouseover of the RadarAxis component are in:
RadarAxis.js
Radar.js
RadarWrapper.js
I have some changes at matthewcocco@8431850 that pass the test:all suite, and can open a PR if you'd like, @shauns -- would you be open to accepting it?
The text was updated successfully, but these errors were encountered:
In the
v-next
branch, theRadarAxis
component calls theonClick
method on mouseover.I believe the cause is here: https://github.com/shauns/react-d3-radar/blob/v-next/src/RadarAxis.js#L71-L72
This causes (what I think is) unexpected behavior for an
onAxisLabelClick
prop passed from the top levelRadar
is triggered every time an axis label is moused over, in addition to when it is clicked.The relevant changes to add an
onAxisLabelMouseover
prop and pass that value instead to theonMouseover
of theRadarAxis
component are in:RadarAxis.js
Radar.js
RadarWrapper.js
I have some changes at matthewcocco@8431850 that pass the
test:all
suite, and can open a PR if you'd like, @shauns -- would you be open to accepting it?The text was updated successfully, but these errors were encountered: