Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Set domainMax for each Key #6

Open
mcoeur opened this issue Oct 4, 2017 · 2 comments
Open

[Feature Request] Set domainMax for each Key #6

mcoeur opened this issue Oct 4, 2017 · 2 comments

Comments

@mcoeur
Copy link

mcoeur commented Oct 4, 2017

First and foremost, thank you for this component !

I would love to be able to specify multiple domainMax (one for each key, and all sets will have the same domainMax for each key of course) so all axes don't have the same scale.

Is there any way to do that ?
If anyone can point me to the place to start, I'd be willing to implement this and create a pull request.

@shauns
Copy link
Owner

shauns commented Oct 4, 2017

Thanks very much! I rarely get to hear how people are finding or using the library.

I think this should be possible. <RadarWrapper/> (the detailed component) only passes it on to draw the axes; instead we could have a dictionary of domainMaxes keyed by key. Inside <Radar/> things are a bit ugly (was originally a private lib) so it could benefit with a nicer API overall!

If you're up for it please go ahead. Otherwise I can do this 👍

@mcoeur
Copy link
Author

mcoeur commented Oct 4, 2017

If you already know how to implement this, you will definitely be faster than me :-)

Otherwise I can give it a try in the weeks to come.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants