Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GUI - view labels tab - dendrogram is plotted thrice on init #753

Closed
shawnlaffan opened this issue Feb 5, 2020 · 2 comments
Closed

GUI - view labels tab - dendrogram is plotted thrice on init #753

shawnlaffan opened this issue Feb 5, 2020 · 2 comments
Assignees
@shawnlaffan
Labels
enhancement GUI
Milestone
Release_3.1

Comments

@shawnlaffan
Copy link
Owner

Profiling indicates the dendrogram is plotted three times when opening the view labels tab. This slows down plotting of large trees.

The issue is due to the tree pane being resized as other panes are adjusted, and the tree is completely regenerated each time.

Ideally it would simply be rescaled, but for now we can avoid plotting until the panes are settled.
@shawnlaffan shawnlaffan added this to the Release_3.1 milestone Feb 5, 2020
@shawnlaffan shawnlaffan self-assigned this Feb 5, 2020
@shawnlaffan
Copy link
Owner Author

Larger issue of scaling is listed under #754

shawnlaffan added a commit that referenced this issue Feb 5, 2020
@shawnlaffan
GUI View Labels: Don't plot the dendrogram until the panes are in pos…
332003a 
…ition

Otherwise we rebuild it three times, and
this takes a while for large trees.

Updates #753
@shawnlaffan
Copy link
Owner Author

Mark as fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shawnlaffan shawnlaffan

Labels
enhancement GUI
Projects
None yet
Milestone
Release_3.1
Development

No branches or pull requests
1 participant
@shawnlaffan