-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature request: downsampling
#18
Comments
What was this function intended for again? |
@hyang336 this function is intended to be a downsampling method -- i.e., bin timeseries into x-ms intervals (in case the user doesn't want the raw data out at 1000Hz (or whatever the tracker recorded at) |
@mh105 @hyang336 @alicexue - quick follow-up question on this: should the binning (ie downsampling) step be its own step, or baked into the epoching step as a flag (or both)? i'm wondering whether folks would be interested in downsampling the data prior to epoching, or if they'd just want to have a more coarse binning of the epoched data. |
If by Which one of these two routes are you thinking? We may potentially want both implemented. |
this is a super helpful distinction, thanks — i think we probably want
both. it would be helpful to have some more context about when you’d want
to do either, since i don’t typically use either of these when analyzing
tonic data (but want to provide flexibility for folks who primarily do
ERP-like analyses)
sent from my iphone
…On Tue, Sep 3, 2024 at 1:06 PM Mingjian He ***@***.***> wrote:
If by binning you are referring to averaging during chunks of trial
periods, then it's not really downsampling. If you are indeed referring
to downsampling (i.e., like how 1000Hz eye tracking data can be
downsampled to 100Hz), then it should be renamed as downsample instead of
bin to remind people that they can't just decimate their data without
worrying about aliasing.
Which one of these two routes are you thinking? We may potentially want
both implemented.
—
Reply to this email directly, view it on GitHub
<#18 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABHVTCTRAJCWWUWXNZGJDCLZUYJDHAVCNFSM6AAAAABNA66MSGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRXGMZTSOJYGM>
.
You are receiving this because you were assigned.Message ID:
***@***.***>
|
Personally I think there are better ways to achieve both My suggestion is to provide both as separate pipeline functions that people can use, but you should be very clear about their distinctions in function header / documentations.
Say the new desired sampling frequency after downsampling is
Then set |
bin.R
binning
and downsampling
binning
and downsampling
downsampling
The text was updated successfully, but these errors were encountered: