Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility to name shortcode different from classname #10

Open
wernerkrauss opened this issue Mar 11, 2015 · 3 comments
Open

Add possibility to name shortcode different from classname #10

wernerkrauss opened this issue Mar 11, 2015 · 3 comments

Comments

@wernerkrauss
Copy link
Contributor

I e.g. have a Youtube shortcode that should be handled by a class YoutubeShortcode.

I propose to add an (optional) method getShortcodeName() to get it. I can submit a PR if you want me to.

@wernerkrauss
Copy link
Contributor Author

Or use config system?

@wernerkrauss
Copy link
Contributor Author

Came around this issue defining a new

class Foo extends Object implements Shortcodable

But some configuration for this would still be need for better encapsulation

@sheadawson
Copy link
Owner

Happy to merge a PR using the config system. Please update the readme too :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants