Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Click shortcode to resume editing #6

Closed
jedateach opened this issue Sep 26, 2014 · 6 comments
Closed

Click shortcode to resume editing #6

jedateach opened this issue Sep 26, 2014 · 6 comments

Comments

@jedateach
Copy link

It would be super useful to be able to open up a shortcode in the popup box again to continue editing.

Perhaps render something clickable in TinyMCE.

This module is definitely progressing towards a more flexible CMS. Allowing rich content, without requiring users to edit in TinyMCE.

@sheadawson
Copy link
Owner

Hey Jeremy,

Currently, if you select shortcode text and click the shortcode toolbar
icon it will open in editing mode. Is that working for you?

On Fri, Sep 26, 2014 at 3:00 PM, Jeremy Shipman [email protected]
wrote:

It would be super useful to be able to open up a shortcode in the popup
box again to continue editing.

Perhaps render something clickable in TinyMCE.

This module is definitely progressing towards a more flexible CMS.


Reply to this email directly or view it on GitHub
#6.

Shea Dawson
Web Developer
LiveSource

mobile +61 451125303
skype squatchnz
email [email protected]
*web *www.livesource.co.nz

@jedateach
Copy link
Author

Yep, it works as you describe. Nice. Would be good if you could just put the cursor inside it, or actually click it.

@jedateach jedateach changed the title Edit shortcode/object details again after creation Click shortcode to resume editing Sep 26, 2014
@sheadawson
Copy link
Owner

Agreed! Feel free to have a go if you're feeling inspired, I won't have time for a wee while :)

@jedateach
Copy link
Author

Here is a good reference for doing this:

http://codex.wordpress.org/The_WordPress_Gallery
https://github.com/WordPress/WordPress/blob/809baf442b0bd4aaedbbc06de8d6d14408a73d7b/wp-includes/js/tinymce/plugins/wpgallery/plugin.js

Handles the display of the placeholder in TinyMce.

Perhaps we could do the same:

  • Wrap tags with some kind of markup on TinyMCE load.
  • Bind events to that markup so Shortcodable editor can open up again.
  • Remove tags on save. Reduce extra markup back down to short codes.

Markup can be styled nicely, perhaps on a per-shortcode basis.
eg: Example

@jonom
Copy link
Contributor

jonom commented Oct 6, 2014

+1 would love to see this enhancement. Haven't tried this module yet but it looks great thanks @sheadawson

@sheadawson
Copy link
Owner

The new placeholders will help with this but still need to fix shortcodes that don't have placeholders. I'll close this issue as it's a less specific duplicate of #11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants