Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad ServerPlayerEntity mixin causes crash on container update #36

Open
unascribed opened this issue Oct 10, 2021 · 0 comments
Open

Bad ServerPlayerEntity mixin causes crash on container update #36

unascribed opened this issue Oct 10, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@unascribed
Copy link

Ref: unascribed/NotEnoughCreativity#28

When making a Mixin extend things to provide access to the target's class hierarchy, you must not implement interfaces that already exist, or you will overwrite the target's implementations of that interface with abstract stubs.

public abstract class MixinServerPlayerEntity extends PlayerEntity implements ScreenHandlerListener {

The implements ScreenHandlerListener must be removed. I have confirmed removing it and recompiling the mod prevents the crash, however there may be other bad mixins in the project I don't know of.

Something about NEC+ causes this otherwise-dormant issue to be activated. With NEC+ and Cloth Common Events installed, using /give or entering Creative+ mode causes the crash in the linked issue. Here's a crash from my minimal repro, using a version of Cloth Common Events built from the latest commit on the 1.17 branch: https://paste.ee/p/9Antr

@shedaniel shedaniel added the bug Something isn't working label Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants