feat: Removed validation 'should throw error if passedValue is undefined'

Author: DrewsAbuse

src/evaluation.test.ts

@@ -127,6 +127,22 @@ describe('expressionToRPN', () => {
     expect(expressionToRPN(expression, variablesValueMap)).toEqual([false]);
   });
 
+  it('should return `[false]` when variables value not passed', () => {
+    const variablesValueMap = new Map();
+
+    const expression: Expression = {
+      rules: [
+        {
+          variableId: 'variable-id-a',
+          operator: 'eq',
+          value: 'a',
+        },
+      ],
+    };
+
+    expect(expressionToRPN(expression, variablesValueMap)).toEqual([false]);
+  });
+
   const variableValueSomething = new Map([['variable-id-a', 'something']]);
 
   it('should return `[true]` for expression and `contains` rule', () => {

src/evaluation.ts

@@ -38,7 +38,7 @@ export const expressionToRPN = (
   const {variableId, operator, value: comparedValue} = expression;
   const passedValue = variableIdToValuesMap.get(variableId);
 
-  validateRuleInvoke({operator, comparedValue, passedValue, variableId});
+  validateRuleInvoke({operator, comparedValue});
 
   return [
     ruleHandlers[operator]({

src/validations.test.ts

@@ -28,8 +28,6 @@ describe('validateRuleInvoke', () => {
       validateRuleInvoke({
         comparedValue: undefined as any,
         operator: 'eq',
-        passedValue: 'a',
-        variableId: 'variable-id-a',
       })
     ).toThrow('Invalid Rule compared value not exist');
   });
@@ -39,20 +37,7 @@ describe('validateRuleInvoke', () => {
       validateRuleInvoke({
         comparedValue: 'a',
         operator: undefined as any,
-        passedValue: 'a',
-        variableId: 'variable-id-a',
       })
     ).toThrow('Invalid Rule operator not exist');
   });
-
-  it('should throw error if passedValue is undefined', () => {
-    expect(() =>
-      validateRuleInvoke({
-        comparedValue: 'a',
-        operator: 'eq',
-        passedValue: undefined as any,
-        variableId: 'variable-id-a',
-      })
-    ).toThrow('Invalid passed variable value with id: variable-id-a');
-  });
 });

src/validations.ts

@@ -13,15 +13,11 @@ export const validateJoinerInvoke = ({
 };
 
 export const validateRuleInvoke = ({
-  passedValue,
-  variableId,
   operator,
   comparedValue,
 }: {
   comparedValue: string;
   operator?: Rule['operator'];
-  passedValue?: string;
-  variableId: string;
 }) => {
   if (comparedValue === undefined) {
     throw new Error(`Invalid Rule compared value not exist`, {
@@ -34,10 +30,4 @@ export const validateRuleInvoke = ({
       cause: 'invalid-expression',
     });
   }
-
-  if (passedValue === undefined) {
-    throw new Error(`Invalid passed variable value with id: ${variableId}`, {
-      cause: 'invalid-expression',
-    });
-  }
 };