Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minify plugin causes Outlook classic to display malformed XML #271

Open
osdiab opened this issue Dec 24, 2024 · 1 comment
Open

Minify plugin causes Outlook classic to display malformed XML #271

osdiab opened this issue Dec 24, 2024 · 1 comment

Comments

@osdiab
Copy link

osdiab commented Dec 24, 2024

  • Component or Package Name: jsx-email
  • Component or Package Version: 2.5.4
  • @jsxp-email/cli Version?: whatever came with it
  • Operating System (or Browser): Server running on Mac OSX (during dev), email client on Windows 11
  • Node Version: 22
  • Link to reproduction (⚠️ read below): umm this is kind of hard since I don't exactly want to provide keys to our Sendgrid account to actually send the emails here. I just installed @jsx-email/plugin-minify and tried sending an email to an outlook account by rendering it with render(<MyTemplate />, { minify: true }), and out came malformed, visible XML. 🤷🏼

Expected Behavior

Email output doesn't change visually

Actual Behavior

Screenshot 2024-12-24 at 15 32 57
  • a bunch of XML at the top
  • the button itself just doesn't show up

after removing minify: true, it works fine:

Screenshot 2024-12-24 at 15 44 14

Additional Information

Probably not relevant but I'm using React 19 in the server, despite jsx-email not officially supporting it.

@osdiab osdiab changed the title Minify plugin causes Outlook classic to be malformed Minify plugin causes Outlook classic to display malformed XML Dec 24, 2024
@shellscape
Copy link
Owner

Interesting, thanks for reporting this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants