Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jsx-email): dont declare exports for cjs build. fixes #235 #236

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

shellscape
Copy link
Owner

Component / Package Name:

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no - We need a separate smoke test for CJS builds because Vitest won't load CJS

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

If yes, please include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.

List any relevant issue numbers: Fixes #235

Description

Prevents a const exports declaration which for some reason results in a TSC compilation error beyond our control.

@shellscape shellscape force-pushed the fix/jsx-email/cjs-bundle-exports branch from d737e5d to 4660bbc Compare November 4, 2024 16:05
@shellscape shellscape merged commit 29851f2 into main Nov 4, 2024
5 checks passed
@shellscape shellscape deleted the fix/jsx-email/cjs-bundle-exports branch November 4, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot access 'exports' before initialization
1 participant