From a74742e2ee5396082a68070b46928489ab5acb0b Mon Sep 17 00:00:00 2001
From: Danno Ferrin <danno.ferrin@swirldslabs.com>
Date: Mon, 6 Nov 2023 13:43:44 -0700
Subject: [PATCH] tests for adding optional v

Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
---
 .../jsonrpc/internal/methods/EthGetTransactionByHashTest.java   | 2 +-
 .../api/jsonrpc/eth/eth_getBlockByNumber_complete_shanghai.json | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/ethereum/api/src/test/java/org/hyperledger/besu/ethereum/api/jsonrpc/internal/methods/EthGetTransactionByHashTest.java b/ethereum/api/src/test/java/org/hyperledger/besu/ethereum/api/jsonrpc/internal/methods/EthGetTransactionByHashTest.java
index 4193f65299d..34ab6ba93eb 100644
--- a/ethereum/api/src/test/java/org/hyperledger/besu/ethereum/api/jsonrpc/internal/methods/EthGetTransactionByHashTest.java
+++ b/ethereum/api/src/test/java/org/hyperledger/besu/ethereum/api/jsonrpc/internal/methods/EthGetTransactionByHashTest.java
@@ -182,7 +182,7 @@ void validateResultSpec() {
     assertThat(result.getTo()).isNotNull();
     assertThat(result.getValue()).isNotNull();
     assertThat(result.getYParity()).isNotNull();
-    assertThat(result.getV()).isNull();
+    assertThat(result.getV()).isNotNull();
     assertThat(result.getR()).isNotNull();
     assertThat(result.getS()).isNotNull();
   }
diff --git a/ethereum/api/src/test/resources/org/hyperledger/besu/ethereum/api/jsonrpc/eth/eth_getBlockByNumber_complete_shanghai.json b/ethereum/api/src/test/resources/org/hyperledger/besu/ethereum/api/jsonrpc/eth/eth_getBlockByNumber_complete_shanghai.json
index 9abe0c50988..fb77fccd598 100644
--- a/ethereum/api/src/test/resources/org/hyperledger/besu/ethereum/api/jsonrpc/eth/eth_getBlockByNumber_complete_shanghai.json
+++ b/ethereum/api/src/test/resources/org/hyperledger/besu/ethereum/api/jsonrpc/eth/eth_getBlockByNumber_complete_shanghai.json
@@ -58,6 +58,7 @@
           "type": "0x2",
           "value": "0x0",
           "yParity": "0x0",
+          "v" : "0x0",
           "r": "0x8abbfbd4c5f2a13a8d5ed394ac50bac7d678f83a23f645818492f76e8ee17ab3",
           "s": "0x7bd38c6929235f775d68b45bd7dea7981264f9a265b6bea97b070e15be88389c"
         }